Ensure login prompt before opening workspace from URI #694
Conversation
When opening a workspace via URI without a token, ensure we prompt for login and set the deployment before attempting to open. Extract URI handler into dedicated module with route-based dispatch.
code-asher
left a comment
code-asher
left a comment
There was a problem hiding this comment.
Awesome, verified the token prompt shows up when the token is invalid or missing.
src/uri/uriHandler.ts
Outdated
| if (token !== null) { | ||
| await secretsManager.setSessionAuth(safeHostname, { url, token }); | ||
| } |
There was a problem hiding this comment.
Should we wait to set the token until after ensureLoggedIn? To avoid potentially storing an invalid or blank token.
Not a huge deal since usually the token should be set and valid, I just noticed that if I am already logged in and the URI contains an invalid or blank token, I get partially logged out (my workspace list is empty but I still look logged-in) and if I reload VS Code I am completely logged out. Just seems unfortunate to lose the perfectly good token I had stored previously.
Actually ensureLoggedIn already sets auth so I suppose we can skip it here. Although, it also sets it before validating. Maybe something we can visit later.
There was a problem hiding this comment.
Oooh that's a valid point, I've added an optional token parameter so we try to login in the following order:
- mTLS (non-token auth)
- Provided token
- Stored token
- User prompt
We store whatever succeeds in this order
* Always return User if the login is successful
2 participants
When opening a workspace via URI without a token, ensure we prompt for login and set the deployment before attempting to open. Extract URI handler into dedicated module with route-based dispatch.
Closes #680